Reviewers: jarin,
Message:
PTAL
Description:
[linux] Use _GLIBCXX_DEBUG in Debug builds by default for better checking.
The _GLIBCXX_DEBUG macro is now set by default for Linux Debug builds
and can be disabled using the disable_glibcxx_debug=1 setting
(compatible with Chrome). This will help us catch problems earlier.
BUG=v8:3638
LOG=n
Please review this at https://codereview.chromium.org/946283003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+8, -6 lines):
M build/standalone.gypi
M build/toolchain.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
56cebbe1f3fd278c7f7531d3c2ce9f1154ff6aac..8ec06fd5e011d44ecd7368f138b99f50fe7582b3
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -177,12 +177,6 @@
'DebugBaseCommon': {
'cflags': [ '-g', '-O0' ],
'conditions': [
- ['(v8_target_arch=="ia32" or v8_target_arch=="x87") and \
- OS=="linux"', {
- 'defines': [
- '_GLIBCXX_DEBUG'
- ],
- }],
[ 'OS=="aix"', {
'cflags': [ '-gxcoff' ],
}],
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index
d4a9403cbd7b8b8d13a762c19a1cca157e52c0b9..b8c73177853fa4ac988b8394dbfc633b272d557f
100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -61,6 +61,9 @@
# Similar to the ARM hard float ABI but on MIPS.
'v8_use_mips_abi_hardfloat%': 'true',
+ # Force disable libstdc++ debug mode.
+ 'disable_glibcxx_debug%': 0,
+
'v8_enable_backtrace%': 0,
# Enable profiling support. Only required on Windows.
@@ -1134,6 +1137,11 @@
# Support for backtrace_symbols.
'ldflags': [ '-rdynamic' ],
}],
+ ['OS=="linux" and disable_glibcxx_debug==0', {
+ # Enable libstdc++ debugging facilities to help catch problems
+ # early, see http://crbug.com/65151 .
+ 'defines': ['_GLIBCXX_DEBUG=1',],
+ }],
['OS=="aix"', {
'ldflags': [ '-Wl,-bbigtoc' ],
}],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
