Reviewers: Erik Corry, Description: Add parentheses to prevent precedence errors. GCC 4.4 catches it: "suggest parentheses around '&&' within '||'"
Please review this at http://codereview.chromium.org/371067 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/jsregexp.cc Index: src/jsregexp.cc =================================================================== --- src/jsregexp.cc (revision 3247) +++ src/jsregexp.cc (working copy) @@ -4077,7 +4077,7 @@ int length = uncanonicalize.get(i, '\0', chars); for (int j = 0; j < length; j++) { uc32 chr = chars[j]; - if (chr != i && chr < bottom || chr > top) { + if (chr != i && (chr < bottom || chr > top)) { characters->Add(chr); } } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
