https://codereview.chromium.org/938443002/diff/80001/src/harmony-spread.js
File src/harmony-spread.js (right):
https://codereview.chromium.org/938443002/diff/80001/src/harmony-spread.js#newcode12
src/harmony-spread.js:12: var array = (new
InternalArray()).concat(%_Arguments(0));
Why not Push. concat creates a new array so we create one too many.
https://codereview.chromium.org/938443002/diff/80001/src/harmony-spread.js#newcode15
src/harmony-spread.js:15: array = array.concat(%_Arguments(i));
push here as well
or roll your own loop. It is usually faster but I'm not sure how much
cruft internal array push has.
https://codereview.chromium.org/938443002/diff/80001/src/harmony-spread.js#newcode27
src/harmony-spread.js:27: var iterator = GetIterator(collection,
iterable);
I'm on a mission to replace all of these with for-of since for-of will
be able to correctly handle the abrubt completion in the future so we
don't have to handle that all over the code base.
https://codereview.chromium.org/938443002/diff/80001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/938443002/diff/80001/src/parser.cc#newcode5497
src/parser.cc:5497: int i = 0;
This could use a comment explaining what it desugars to.
https://codereview.chromium.org/938443002/diff/80001/src/parser.cc#newcode5508
src/parser.cc:5508: args->Add(factory()->NewArrayLiteral(unspread,
literal_index,
Will this be observable if someone overrides
Array.prototoype[Symbol.iterator]?
https://codereview.chromium.org/938443002/diff/80001/src/runtime/runtime-function.cc
File src/runtime/runtime-function.cc (right):
https://codereview.chromium.org/938443002/diff/80001/src/runtime/runtime-function.cc#newcode578
src/runtime/runtime-function.cc:578: DCHECK(args.length() == 5 ||
args.length() == 3);
I think it would be cleaner to have to functions.
https://codereview.chromium.org/938443002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
