https://codereview.chromium.org/947153002/diff/20001/src/utils.h
File src/utils.h (right):
https://codereview.chromium.org/947153002/diff/20001/src/utils.h#newcode211
src/utils.h:211: static const T kMax = static_cast<T>((kOne << size) -
1);
On 2015/02/23 18:33:49, Benedikt Meurer wrote:
The looks a lot like undefined behavior for signed T's to me. Can we
avoid that
somehow?
this doesn't change the current behaviour, just makes it correct for
BitField64. kMax probably shouldn't be exposed to the world, just used
for the is_valid calculation, where it's anyway converted back to
unsigned
https://codereview.chromium.org/947153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
