https://codereview.chromium.org/947683002/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/947683002/diff/20001/src/hydrogen.cc#newcode12151
src/hydrogen.cc:12151: IfBuilder string_checker(this);
On 2015/02/23 18:43:34, adamk wrote:
On 2015/02/23 09:26:53, Sven Panne wrote:
> As a general rule of thumb, we should not have any non-trivial
control flow in
> intrinsics. This should be expressed on the JavaScript level.
Thanks, this is good feedback. "No non-trivial control flow" is a
guideline I
didn't have in mind for these, but now I do.
One more issue here: the hash field in Strings uses an Integer32
representation. What's your recommended way to return such a thing to
JS?
https://codereview.chromium.org/947683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
