Reviewers: Benedikt Meurer,
Description:
[turbofan] Only compile hot asm functions with TurboFan if --turbo-osr flag
is
turned on.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/951053002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -1 lines):
M src/compiler.cc
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
4b8157bee6a274ce3594391ec9e7244e03fd9d6c..f3f8dbd086d3288d5e51214f8cdc8a3880367203
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -501,6 +501,11 @@ OptimizedCompileJob::Status
OptimizedCompileJob::CreateGraph() {
if (info()->is_osr()) os << " OSR";
os << "]" << std::endl;
}
+
+ if (info()->shared_info()->asm_function()) {
+ info()->MarkAsContextSpecializing();
+ }
+
Timer t(this, &time_taken_to_create_graph_);
compiler::Pipeline pipeline(info());
pipeline.GenerateCode();
@@ -930,7 +935,8 @@ MaybeHandle<Code>
Compiler::GetLazyCode(Handle<JSFunction> function) {
// If the debugger is active, do not compile with turbofan unless we can
// deopt from turbofan code.
if (FLAG_turbo_asm && function->shared()->asm_function() &&
- (FLAG_turbo_deoptimization || !isolate->debug()->is_active())) {
+ (FLAG_turbo_deoptimization || !isolate->debug()->is_active()) &&
+ !FLAG_turbo_osr) {
CompilationInfoWithZone info(function);
VMState<COMPILER> state(isolate);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.