Reviewers: tandrii(chromium), Hablich,
Message:
PTAL. This was now performed manually over the last two weeks. After this
change, we can reactivate the auto-roller.
Description:
Switch on new branching model in auto-push script.
BUG=chromium:391261
LOG=n
[email protected]
NOTRY=true
TEST=./script_test.py
Please review this at https://codereview.chromium.org/955613003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -8 lines):
M tools/release/auto_push.py
Index: tools/release/auto_push.py
diff --git a/tools/release/auto_push.py b/tools/release/auto_push.py
index
121288f5b532d17b13edf568d020674e62b9ef35..a876d7378ba500253dac649a60669fae162f9206
100755
--- a/tools/release/auto_push.py
+++ b/tools/release/auto_push.py
@@ -34,7 +34,7 @@ import sys
import urllib
from common_includes import *
-import push_to_candidates
+import create_release
class Preparation(Step):
@@ -67,11 +67,11 @@ class LastReleaseBailout(Step):
return True
-class PushToCandidates(Step):
- MESSAGE = "Pushing to candidates if specified."
+class CreateRelease(Step):
+ MESSAGE = "Creating release if specified."
def RunStep(self):
- print "Pushing candidate %s to candidates." % self["candidate"]
+ print "Creating release for %s." % self["candidate"]
args = [
"--author", self._options.author,
@@ -83,16 +83,15 @@ class PushToCandidates(Step):
if self._options.work_dir:
args.extend(["--work-dir", self._options.work_dir])
- # TODO(machenbach): Update the script before calling it.
if self._options.push:
self._side_effect_handler.Call(
- push_to_candidates.PushToCandidates().Run, args)
+ create_release.CreateRelease().Run, args)
class AutoPush(ScriptsBase):
def _PrepareOptions(self, parser):
parser.add_argument("-p", "--push",
- help="Push to candidates. Dry run if unspecified.",
+ help="Create release. Dry run if unspecified.",
default=False, action="store_true")
def _ProcessOptions(self, options):
@@ -112,7 +111,7 @@ class AutoPush(ScriptsBase):
Preparation,
FetchCandidate,
LastReleaseBailout,
- PushToCandidates,
+ CreateRelease,
]
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
