lgtm
https://codereview.chromium.org/953893002/diff/1/tools/run_perf.py
File tools/run_perf.py (right):
https://codereview.chromium.org/953893002/diff/1/tools/run_perf.py#newcode536
tools/run_perf.py:536: def _PushFile(self, host_dir, file_name,
target_rel=".", only_existing=True):
Maybe it's just me, but I was confused by the param name
'only_existing'. I had initially read 'only_existing' as: push only if
the file exists, and ignore if it doesn't. But it actually means the
opposite.
Maybe:
- must_exist=True
- or: skip_if_missing=False (and then invert the logic)
https://codereview.chromium.org/953893002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
