Reviewers: jochen (slow), Jakob, tandrii(chromium),
Message:
PTAL. The landmines script is c/p from chromium's current
landmines script. All differences are highlighted in comments
below. The gyp env setup method is a copy of our own old
setup method.
https://codereview.chromium.org/955463002/diff/20001/build/landmines.py
File build/landmines.py (right):
https://codereview.chromium.org/955463002/diff/20001/build/landmines.py#newcode55
build/landmines.py:55: elif build_tool in ['msvs', 'vs', 'ib']:
This is different to chromium's landmines script which has no default
anymore for 'msvs', 'vs'.
https://codereview.chromium.org/955463002/diff/20001/build/landmines.py#newcode163
build/landmines.py:163: if os.path.isdir(path) and
re.search(r"(?:[Rr]elease)|(?:[Dd]ebug)", f):
This is different to chromium's landmines script. Only delete
directories that are called *release* or *debug*.
Description:
Port chromium landmines script.
This runs the landmines script as a gclient hook. It can
as such be used to clobber local checkouts when hooks are
run locally.
It is a softer version than chromium's landmines script, as
it only deletes directories in the output directory due
to compatibility with MSVS which has "build" hardcoded as
output directory in several places.
BUG=chromium:403263
LOG=n
Please review this at https://codereview.chromium.org/955463002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+192, -75 lines):
M .gitignore
M DEPS
A build/gyp_environment.py
M build/gyp_v8
M build/landmine_utils.py
M build/landmines.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
