https://codereview.chromium.org/953983002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/953983002/diff/1/src/parser.cc#newcode1256
src/parser.cc:1256: void* Parser::ParseModule(ZoneList<Statement*>*
body, bool* ok) {
On 2015/02/24 22:13:34, arv wrote:
Why return void* and not void?
For CHECK_OK.
We could do something else, like have two different sections of parse
methods that use CHECK_OK, not use CHECK_OK in void methods, or add
CHECK_OK_VOID.
https://codereview.chromium.org/953983002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/953983002/diff/1/test/cctest/test-parsing.cc#newcode5228
test/cctest/test-parsing.cc:5228:
parser.set_allow_harmony_classes(true);
On 2015/02/24 22:13:34, arv wrote:
no need for classes here
Removed.
https://codereview.chromium.org/953983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
