LGTM. I love it! Just nits.
https://codereview.chromium.org/957673004/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/957673004/diff/1/src/flag-definitions.h#newcode792
src/flag-definitions.h:792: #define FLAG FLAG_FULL
nit: Can we move the mark-compact.cc flags up a few lines (i.e. to
around line 755)? Then redefining the FLAG to FLAG_FULL here wouldn't be
necessary. WDYT?
https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):
https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc#newcode1938
src/gdb-jit.cc:1938: struct SplayTreeConfig {
Splay tree is best tree. :)
https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.cc#newcode2170
src/gdb-jit.cc:2170: } // namespace v8::internal::GDBJITInterface
nit: Likewise.
https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.h
File src/gdb-jit.h (right):
https://codereview.chromium.org/957673004/diff/1/src/gdb-jit.h#newcode38
src/gdb-jit.h:38: } // namespace v8::internal
nit: Better use the following style, then clang-format is less confused:
} // namespace internal
} // namespace v8
https://codereview.chromium.org/957673004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
