[v8-dev] [x86] Use better left operand heuristic for Float64Add and Float64Mul. (issue 958583003 by [email protected])

Wed, 25 Feb 2015 03:50:03 -0800 

Reviewers: dcarney,

Description:
[x86] Use better left operand heuristic for Float64Add and Float64Mul.

[email protected]

Please review this at https://codereview.chromium.org/958583003/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+28, -16 lines):
  M src/compiler/ia32/instruction-selector-ia32.cc
  M src/compiler/x64/instruction-selector-x64.cc


Index: src/compiler/ia32/instruction-selector-ia32.cc
diff --git a/src/compiler/ia32/instruction-selector-ia32.cc b/src/compiler/ia32/instruction-selector-ia32.cc index 56af208bf437e7c73252729523fb998723674687..7b945faa95990c3047f4b73e5df9d06bea26f1ef 100644 
--- a/src/compiler/ia32/instruction-selector-ia32.cc
+++ b/src/compiler/ia32/instruction-selector-ia32.cc
@@ -634,12 +634,15 @@ void InstructionSelector::VisitTruncateFloat64ToFloat32(Node* node) { 

 void InstructionSelector::VisitFloat64Add(Node* node) {
   IA32OperandGenerator g(this);
+  Node* left = node->InputAt(0);
+  Node* right = node->InputAt(1);
+  if (g.CanBeBetterLeftOperand(right)) std::swap(left, right);
   if (IsSupported(AVX)) {
-    Emit(kAVXFloat64Add, g.DefineAsRegister(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kAVXFloat64Add, g.DefineAsRegister(node), g.UseRegister(left),
+         g.Use(right));
   } else {
-    Emit(kSSEFloat64Add, g.DefineSameAsFirst(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kSSEFloat64Add, g.DefineSameAsFirst(node), g.UseRegister(left),
+         g.Use(right));
   }
 }
@@ -658,12 +661,15 @@ void InstructionSelector::VisitFloat64Sub(Node* node) { 

 void InstructionSelector::VisitFloat64Mul(Node* node) {
   IA32OperandGenerator g(this);
+  Node* left = node->InputAt(0);
+  Node* right = node->InputAt(1);
+  if (g.CanBeBetterLeftOperand(right)) std::swap(left, right);
   if (IsSupported(AVX)) {
-    Emit(kAVXFloat64Mul, g.DefineAsRegister(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kAVXFloat64Mul, g.DefineAsRegister(node), g.UseRegister(left),
+         g.Use(right));
   } else {
-    Emit(kSSEFloat64Mul, g.DefineSameAsFirst(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kSSEFloat64Mul, g.DefineSameAsFirst(node), g.UseRegister(left),
+         g.Use(right));
   }
 }

Index: src/compiler/x64/instruction-selector-x64.cc
diff --git a/src/compiler/x64/instruction-selector-x64.cc b/src/compiler/x64/instruction-selector-x64.cc index c1328b3ee30683f9c1324e5eec8abe3d59c3d646..f10ad06cb07708dfdb2f33b672e340fff80c569b 100644 
--- a/src/compiler/x64/instruction-selector-x64.cc
+++ b/src/compiler/x64/instruction-selector-x64.cc
@@ -832,12 +832,15 @@ void InstructionSelector::VisitTruncateInt64ToInt32(Node* node) { 

 void InstructionSelector::VisitFloat64Add(Node* node) {
   X64OperandGenerator g(this);
+  Node* left = node->InputAt(0);
+  Node* right = node->InputAt(1);
+  if (g.CanBeBetterLeftOperand(right)) std::swap(left, right);
   if (IsSupported(AVX)) {
-    Emit(kAVXFloat64Add, g.DefineAsRegister(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kAVXFloat64Add, g.DefineAsRegister(node), g.UseRegister(left),
+         g.Use(right));
   } else {
-    Emit(kSSEFloat64Add, g.DefineSameAsFirst(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kSSEFloat64Add, g.DefineSameAsFirst(node), g.UseRegister(left),
+         g.Use(right));
   }
 }
@@ -856,12 +859,15 @@ void InstructionSelector::VisitFloat64Sub(Node* node) { 

 void InstructionSelector::VisitFloat64Mul(Node* node) {
   X64OperandGenerator g(this);
+  Node* left = node->InputAt(0);
+  Node* right = node->InputAt(1);
+  if (g.CanBeBetterLeftOperand(right)) std::swap(left, right);
   if (IsSupported(AVX)) {
-    Emit(kAVXFloat64Mul, g.DefineAsRegister(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kAVXFloat64Mul, g.DefineAsRegister(node), g.UseRegister(left),
+         g.Use(right));
   } else {
-    Emit(kSSEFloat64Mul, g.DefineSameAsFirst(node),
-         g.UseRegister(node->InputAt(0)), g.Use(node->InputAt(1)));
+    Emit(kSSEFloat64Mul, g.DefineSameAsFirst(node), g.UseRegister(left),
+         g.Use(right));
   }
 }



--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to