Maybe I'm overlooking something, but the &global_procy_object thing doesn't
look
quite right to me.
https://codereview.chromium.org/957703003/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/957703003/diff/1/src/serialize.cc#newcode711
src/serialize.cc:711: SetAttachedObjects(attached_objects);
I don't get this. My understanding is:
- SetAttachedObjects will make a (shallow) copy of attached_objects.
- So attached_objects can go out of scope, but its content can't.
- But global_proxy_object will go out of scope - it's stack allocated.
Won't Deserializer::attached_objects_ now have an invalid reference to
it after exiting this method?
https://codereview.chromium.org/957703003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
