Reviewers: Michael Starzinger,
Description:
Remove effectful assertion
[email protected]
BUG=461520
LOG=N
Please review this at https://codereview.chromium.org/955973003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+18, -7 lines):
M src/runtime/runtime-scopes.cc
A test/mjsunit/harmony/regress/regress-crbug-461520.js
Index: src/runtime/runtime-scopes.cc
diff --git a/src/runtime/runtime-scopes.cc b/src/runtime/runtime-scopes.cc
index
201bf9d4c683030fcdcc3a15d94a7b51b02869ca..7bba26314b2ee276db27d038a64a18575bf01ecc
100644
--- a/src/runtime/runtime-scopes.cc
+++ b/src/runtime/runtime-scopes.cc
@@ -933,13 +933,6 @@ static ObjectPair LoadLookupSlotHelper(Arguments args,
Isolate* isolate,
// property from it.
if (!holder.is_null()) {
Handle<JSReceiver> object = Handle<JSReceiver>::cast(holder);
-#ifdef DEBUG
- if (!object->IsJSProxy()) {
- Maybe<bool> maybe = JSReceiver::HasProperty(object, name);
- DCHECK(maybe.has_value);
- DCHECK(maybe.value);
- }
-#endif
// GetProperty below can cause GC.
Handle<Object> receiver_handle(
object->IsGlobalObject()
Index: test/mjsunit/harmony/regress/regress-crbug-461520.js
diff --git a/test/mjsunit/harmony/regress/regress-crbug-461520.js
b/test/mjsunit/harmony/regress/regress-crbug-461520.js
new file mode 100644
index
0000000000000000000000000000000000000000..c30260db72ad16f95c2b0ded0571f8a15c09eca9
--- /dev/null
+++ b/test/mjsunit/harmony/regress/regress-crbug-461520.js
@@ -0,0 +1,18 @@
+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --harmony-proxies
+
+var fuse = 1;
+var handler = {
+ get: function() { return function() {} },
+ getPropertyDescriptor: function() {
+ if (fuse-- == 0) throw "please die";
+ return {value: function() {}, configurable: true};
+ }
+};
+
+var p = Proxy.create(handler);
+var o = Object.create(p);
+with (o) { f() }
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
