Reviewers: paul.l..., dusmil.imgtec, gergely.kis.imgtec, akos.palfi.imgtec,
Jakob, danno,
Description:
MIPS: Fix 'MIPS: Move Maps' back pointers from "transitions"
to "constructor"
field'.
BUG=
Please review this at https://codereview.chromium.org/950523003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -4 lines):
M src/mips/lithium-codegen-mips.cc
M src/mips/macro-assembler-mips.cc
M src/mips64/lithium-codegen-mips64.cc
M src/mips64/macro-assembler-mips64.cc
Index: src/mips/lithium-codegen-mips.cc
diff --git a/src/mips/lithium-codegen-mips.cc
b/src/mips/lithium-codegen-mips.cc
index
3be283de831ad40240e83daafb6c1cf5044f8cc9..07e48db05c2e722b4a0c59dfc3ba70ab11f22323
100644
--- a/src/mips/lithium-codegen-mips.cc
+++ b/src/mips/lithium-codegen-mips.cc
@@ -2659,7 +2659,6 @@ void LCodeGen::EmitClassOfTest(Label* is_true,
// Check if the constructor in the map is a function.
Register instance_type = scratch1();
DCHECK(!instance_type.is(temp));
- DCHECK(!instance_type.is(temp2));
__ GetMapConstructor(temp, temp, temp2, instance_type);
// Objects with a non-function constructor have class 'Object'.
Index: src/mips/macro-assembler-mips.cc
diff --git a/src/mips/macro-assembler-mips.cc
b/src/mips/macro-assembler-mips.cc
index
de3c08afff060855886bbdf8490e51fb1fad6b59..6c07e6863af97f882c20c16f97a2b356775a9ca5
100644
--- a/src/mips/macro-assembler-mips.cc
+++ b/src/mips/macro-assembler-mips.cc
@@ -4387,7 +4387,7 @@ void MacroAssembler::TryGetFunctionPrototype(Register
function,
// Non-instance prototype: Fetch prototype from constructor field
// in initial map.
bind(&non_instance);
- GetMapConstructor(result, result, scratch, at);
+ GetMapConstructor(result, result, scratch, scratch);
}
// All done.
Index: src/mips64/lithium-codegen-mips64.cc
diff --git a/src/mips64/lithium-codegen-mips64.cc
b/src/mips64/lithium-codegen-mips64.cc
index
bb256bff3cf89cb0bdfa30fc6583438eb2a60ec8..89884ed90168994b3755a1b27912806d6c30b352
100644
--- a/src/mips64/lithium-codegen-mips64.cc
+++ b/src/mips64/lithium-codegen-mips64.cc
@@ -2620,7 +2620,6 @@ void LCodeGen::EmitClassOfTest(Label* is_true,
// Check if the constructor in the map is a function.
Register instance_type = scratch1();
DCHECK(!instance_type.is(temp));
- DCHECK(!instance_type.is(temp2));
__ GetMapConstructor(temp, temp, temp2, instance_type);
// Objects with a non-function constructor have class 'Object'.
Index: src/mips64/macro-assembler-mips64.cc
diff --git a/src/mips64/macro-assembler-mips64.cc
b/src/mips64/macro-assembler-mips64.cc
index
bc935326cfe1aac1e816742154a45e0bcc0aeca6..c6305f05d89b973bd91f1e4963fe4857ce04af2d
100644
--- a/src/mips64/macro-assembler-mips64.cc
+++ b/src/mips64/macro-assembler-mips64.cc
@@ -4309,7 +4309,7 @@ void MacroAssembler::TryGetFunctionPrototype(Register
function,
// Non-instance prototype: Fetch prototype from constructor field
// in initial map.
bind(&non_instance);
- GetMapConstructor(result, result, scratch, at);
+ GetMapConstructor(result, result, scratch, scratch);
}
// All done.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
