Reviewers: Michael Starzinger,
https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction-selector.h
File src/compiler/instruction-selector.h (right):
https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction-selector.h#newcode24
src/compiler/instruction-selector.h:24: class BasicBlock;
On 2015/02/25 14:59:37, Michael Starzinger wrote:
nit: Please alpha-sort.
Done.
https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction.h
File src/compiler/instruction.h (right):
https://codereview.chromium.org/951553005/diff/80001/src/compiler/instruction.h#newcode695
src/compiler/instruction.h:695: // TODO(dcarney): remove this class and
just use an uint32_t.
On 2015/02/25 14:59:37, Michael Starzinger wrote:
suggestion: Not sure about this TODO, better ask Benedikt about his
opinion.
removed TODO for now.
https://codereview.chromium.org/951553005/diff/80001/src/compiler/jump-threading.cc
File src/compiler/jump-threading.cc (right):
https://codereview.chromium.org/951553005/diff/80001/src/compiler/jump-threading.cc#newcode12
src/compiler/jump-threading.cc:12: typedef RpoNumber RpoNumber;
On 2015/02/25 14:59:37, Michael Starzinger wrote:
nit: Redundant typedef is redundant.
Done.
https://codereview.chromium.org/951553005/diff/80001/src/compiler/schedule.cc
File src/compiler/schedule.cc (right):
https://codereview.chromium.org/951553005/diff/80001/src/compiler/schedule.cc#newcode316
src/compiler/schedule.cc:316: for (BasicBlock* block : *s.rpo_order()) {
On 2015/02/25 14:59:37, Michael Starzinger wrote:
Since this printer already iterates the rpo_order vector, it can only
be applied
on a sealed schedule. Hence we can also print "B{rpo_number}" here as
well.
sweet. done
https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/test-instruction.cc
File test/cctest/compiler/test-instruction.cc (left):
https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/test-instruction.cc#oldcode134
test/cctest/compiler/test-instruction.cc:134:
CHECK_EQ(block->id().ToInt(), R.BlockAt(block)->id().ToInt());
On 2015/02/25 14:59:37, Michael Starzinger wrote:
Can we preserve this check? It should still hold, right?
Done.
https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/test-jump-threading.cc
File test/cctest/compiler/test-jump-threading.cc (right):
https://codereview.chromium.org/951553005/diff/80001/test/cctest/compiler/test-jump-threading.cc#newcode16
test/cctest/compiler/test-jump-threading.cc:16: typedef RpoNumber
RpoNumber;
On 2015/02/25 14:59:37, Michael Starzinger wrote:
nit: Redundant typedef is redundant.
Done.
Description:
[turbofan] remove dependence of InstructionBlock on BasicBlock
BUG=
Please review this at https://codereview.chromium.org/951553005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+178, -191 lines):
M src/compiler/arm/code-generator-arm.cc
M src/compiler/arm64/code-generator-arm64.cc
M src/compiler/code-generator.h
M src/compiler/code-generator.cc
M src/compiler/code-generator-impl.h
M src/compiler/graph-visualizer.cc
M src/compiler/ia32/code-generator-ia32.cc
M src/compiler/instruction.h
M src/compiler/instruction.cc
M src/compiler/instruction-selector.h
M src/compiler/instruction-selector.cc
M src/compiler/instruction-selector-impl.h
M src/compiler/jump-threading.h
M src/compiler/jump-threading.cc
M src/compiler/mips/code-generator-mips.cc
M src/compiler/mips64/code-generator-mips64.cc
M src/compiler/pipeline.cc
M src/compiler/ppc/code-generator-ppc.cc
M src/compiler/register-allocator.cc
M src/compiler/register-allocator-verifier.cc
M src/compiler/schedule.h
M src/compiler/schedule.cc
M src/compiler/verifier.cc
M src/compiler/x64/code-generator-x64.cc
M test/cctest/compiler/test-instruction.cc
M test/cctest/compiler/test-jump-threading.cc
M test/unittests/compiler/instruction-selector-unittest.cc
M test/unittests/compiler/instruction-sequence-unittest.h
M test/unittests/compiler/instruction-sequence-unittest.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
