I think, despite being observable, the big I'd probably ok if this can't be
implemented in the compiler at this time. My personal opinion is, it is a
really
small impact on the compiler, it makes more sense, it's smaller and it works
better. Realistically I think it will cause fewer headaches there, rather
than
making the parser crazier.
If people aren't convinced of either of these, i guess removing the
assignment
op is the thing to do
https://codereview.chromium.org/952243002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/952243002/diff/1/src/parser.cc#newcode524
src/parser.cc:524: AstValueFactory* ast_value_factory =
parser_->ast_value_factory();
On 2015/02/25 16:58:25, arv wrote:
just inline this
Acknowledged.
https://codereview.chromium.org/952243002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
