https://codereview.chromium.org/948303004/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/948303004/diff/1/src/parser.h#newcode716
src/parser.h:716: ZoneList<ImportDeclaration*>* ParseNamedImports(int
pos, bool* ok);
On 2015/02/25 21:43:12, adamk wrote:
On 2015/02/25 16:07:25, arv wrote:
> On 2015/02/25 13:55:49, rossberg wrote:
> > While you're at it, can you perhaps change the other above
functions to
> _return_
> > their lists as well? I don't see a good reason why they are
created by the
> > caller.
>
> The one above has 2 lists as out params.
Would be fine changing ParseStatementList and ParseModule (to-be-named
ParseModuleItemList) to return their arguments, though I'd rather do
it in a
different patch.
Actually, there is a reason for passing in body there:
ParseStatementList has multiple callers, and one of them already has a
ZoneList<Statement*> with some statements in it before passing it in.
Not sure this is worth changing for now.
https://codereview.chromium.org/948303004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
