Addressed comments
https://codereview.chromium.org/952303002/diff/20001/src/liveedit.cc
File src/liveedit.cc (right):
https://codereview.chromium.org/952303002/diff/20001/src/liveedit.cc#newcode1013
src/liveedit.cc:1013: Handle<FixedArray> old_literals(fun->literals());
On 2015/02/25 21:32:33, Michael Starzinger wrote:
nit: The old_literals handle seems to be unused.
Done.
https://codereview.chromium.org/952303002/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/952303002/diff/20001/src/objects.h#newcode7577
src/objects.h:7577: static Context*
NativeContextFromLiterals(FixedArray* literals);
On 2015/02/25 21:32:33, Michael Starzinger wrote:
nit: Implementation is gone, let's also remove the declaration.
Done.
https://codereview.chromium.org/952303002/diff/20001/src/runtime/runtime-regexp.cc
File src/runtime/runtime-regexp.cc (right):
https://codereview.chromium.org/952303002/diff/20001/src/runtime/runtime-regexp.cc#newcode932
src/runtime/runtime-regexp.cc:932: // from another context which we
should not have access to.
On 2015/02/25 21:32:33, Michael Starzinger wrote:
nit: The entire comment is obsolete. Let's drop it.
Done.
https://codereview.chromium.org/952303002/diff/20001/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/952303002/diff/20001/test/cctest/test-heap-profiler.cc#newcode2297
test/cctest/test-heap-profiler.cc:2297: // The second value in the
literals array should be the boilerplate,
On 2015/02/25 21:32:33, Michael Starzinger wrote:
nit: This comment is confusing, should we s/second/first/ here?
Done.
https://codereview.chromium.org/952303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
