On 2015/02/26 16:38:13, arv wrote:
Marja, this breaks the strong mode tests:
/media/arv/Source/gclient-v8/v8/test/mjsunit/strong/declaration-after-use.js:183:
ReferenceError: Please declare variable 'C1' before use in strong mode
class C1 { constructor() { C1; } }; new C1();
I'm not really sure what to do about that. I think the solution we
currently
have for strong mode is not going to fly here.
I'm tempted to disable the strong mode tests but I'm also not clear what
behavior we actually want for strong mode.
I think it's fine to disable that test for now.
https://codereview.chromium.org/961823002/diff/40001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/961823002/diff/40001/src/parser.cc#newcode4161
src/parser.cc:4161: proxy->var()->set_initializer_position(end_pos);
Marja, this was changed in
https://github.com/v8/v8-git-mirror/commit/1eddcf5b712c4a3c366a9a011e5b5b61a9f78315.
Sorry for missing this in the review.
The name is in TDZ until after the whole class body.
Ah, sorry, I missed this, too.
So this change should actually make strong mode checks for computed property
names work correctly, but instead breaks methods. But that seems natural,
methods need some special handling around this sort of class
self-recursion, the
same way (mutually) recursive functions do.
https://codereview.chromium.org/961823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
