https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/959203002/diff/20001/src/assembler.cc#newcode1663
src/assembler.cc:1663: int raw_position = position.IsUnknown() ? 0 :
position.raw();
Can we change SourcePosition so that raw() value of
SourcePosition::Unknown() is 0 and avoid this code? Otherwise we rely on
the fact that position.raw() cannot return 0 which is non-obvious.
https://codereview.chromium.org/959203002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/959203002/diff/20001/src/objects.cc#newcode11269
src/objects.cc:11269: if (info.deopt_reason != Deoptimizer::kNoReason ||
pos.raw() != 0) {
pos.raw() != 0 ==> !pos.IsUnknown()
https://codereview.chromium.org/959203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
