Just one nit, looks pretty good. Also, just a reminder per our discussion
on the
MORE_THAN_ONE case where we weren't sure if eax was initialized with the
correct
number of arguments.
https://codereview.chromium.org/975463002/diff/20001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/975463002/diff/20001/src/ia32/code-stubs-ia32.cc#newcode4679
src/ia32/code-stubs-ia32.cc:4679: __ add(eax, Immediate(2));
A comment about the add would be good, or maybe an overview comment
indicating that you are cleverly altering the arguments length.
https://codereview.chromium.org/975463002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
