Some comments.
Honestly I think the better solution, and more flexible too, is to
introduce %i
that expands to the isolate id. Then we could remove --logfile-per-isolate.
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-posix.cc
File src/base/platform/platform-posix.cc (right):
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-posix.cc#newcode360
src/base/platform/platform-posix.cc:360: return (ch == '/');
brackets unnecessary.
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-win32.cc
File src/base/platform/platform-win32.cc (right):
https://codereview.chromium.org/960813004/diff/1/src/base/platform/platform-win32.cc#newcode579
src/base/platform/platform-win32.cc:579: return (ch == '/' || ch ==
'\\');
brackets unnecessary.
https://codereview.chromium.org/960813004/diff/1/src/log.cc
File src/log.cc (right):
https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1773
src/log.cc:1773: slash_count++;
no line break after if.
https://codereview.chromium.org/960813004/diff/1/src/log.cc#newcode1785
src/log.cc:1785: } else if (*p == '%') {
How about
if (*p == '%') {
...
} else {
if (base::OS::isDirectorySeparator(*p)) slash_count--;
os << *p;
}
https://codereview.chromium.org/960813004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
