On 2015/03/03 10:23:54, rmcilroy wrote:
On 2015/03/02 15:08:49, Michael Starzinger wrote:
> Thanks for the feedback. Now all I have to fix is Win64. :(
>
>
https://codereview.chromium.org/960273002/diff/110020/src/arm/code-stubs-arm.cc
> File src/arm/code-stubs-arm.cc (right):
>
>
https://codereview.chromium.org/960273002/diff/110020/src/arm/code-stubs-arm.cc#newcode974
> src/arm/code-stubs-arm.cc:974: __ tst(cp, cp);
> On 2015/03/02 14:55:29, Rodolph Perfetta wrote:
> > minor nit (and present in the original code): on ARM cmp(cp,
Operand(0));
is
> > more efficient.
>
> Done.
>
>
https://codereview.chromium.org/960273002/diff/110020/src/arm64/code-stubs-arm64.cc
> File src/arm64/code-stubs-arm64.cc (right):
>
>
https://codereview.chromium.org/960273002/diff/110020/src/arm64/code-stubs-arm64.cc#newcode1038
> src/arm64/code-stubs-arm64.cc:1038:
> On 2015/03/02 14:55:29, Rodolph Perfetta wrote:
> > add DCHECK(csp.Is(StackPointer()));
>
> Done.
lgtm, thanks.
LGTM.
https://codereview.chromium.org/960273002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
