On 2015/03/03 14:59:41, jayconrod wrote:
I don't think this will solve the problem I was having. At the time we
call
CreateSnapshotDataBlob, Locker hasn't been used yet, but another task can
create
an isolate with a Locker in parallel. So by the time the HandleScope is
created
inside CreateSnapshotDataBlob, Locker::IsActive will be true, and we'll
hit
that
assertion.
Maybe another solution would be to add a flag to v8::internal::Isolate
indicating whether or not locking is expected to be used with each
isolate.
CreateSnapshotDataBlob would set this flag to false.
HandleScope::Initialize
could check that flag instead of (or in addition to) Locker::IsActive.
Since
CreateSnapshotDataBlob is the only thing that creates an isolate
internally,
there's probably no need to expose this flag in the API.
I see.
https://codereview.chromium.org/962963007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
