How much does this give us & on which benchmark?
https://codereview.chromium.org/975043002/diff/20001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/975043002/diff/20001/src/scanner.cc#newcode797
src/scanner.cc:797: if (c0_ > 127) {
I was briefly confused by the 127. Why so restrictive? We could have
other strings here too which could go to the fast path, not only under
127.
You could add a comment here that this is a fast path for ascii strings
or sth?
https://codereview.chromium.org/975043002/diff/20001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/975043002/diff/20001/src/scanner.h#newcode578
src/scanner.h:578: if (unibrow::Utf16::IsLeadSurrogate(c0_)) {
So this function is also called when c0_ is not a lead surrogate, and
that's normal, right? I was briefly confused b/c of the name.
https://codereview.chromium.org/975043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
