Can you clarify why we need this? Are there any android_x64 devices?
https://codereview.chromium.org/966773005/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/966773005/diff/1/Makefile#newcode237
Makefile:237: ANDROID_ARCHES = android_ia32 android_x64 android_arm
android_arm64 android_mipsel android_x87
nit: please use \ to maintain 80-col (like GYPFILES below)
https://codereview.chromium.org/966773005/diff/1/build/android.gypi
File build/android.gypi (right):
https://codereview.chromium.org/966773005/diff/1/build/android.gypi#newcode46
build/android.gypi:46: 'android_lib': '<(android_sysroot)/usr/lib',
doesn't this need to be conditional too?
https://codereview.chromium.org/966773005/diff/1/build/android.gypi#newcode56
build/android.gypi:56: ['target_arch=="x64"', {
doesn't "arm64" need to be included in this list?
https://codereview.chromium.org/966773005/diff/1/tools/testrunner/local/statusfile.py
File tools/testrunner/local/statusfile.py (right):
https://codereview.chromium.org/966773005/diff/1/tools/testrunner/local/statusfile.py#newcode57
tools/testrunner/local/statusfile.py:57: "android_arm", "android_arm64",
"android_ia32", "android_x87", "android_x64",
nit: 80-col
https://codereview.chromium.org/966773005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
