I moved the call to OS::ArmCpuHasFeature inside an ifdef so it shouldn't be missing on other platforms when using the simulator. If anyone ports V8 to a non-Linux ARM platform it will be missing, but that will be a useful piece of information to the porter.
http://codereview.chromium.org/385069/diff/1/7 File src/arm/assembler-arm.h (right): http://codereview.chromium.org/385069/diff/1/7#newcode444 Line 444: class Scope BASE_EMBEDDED { On 2009/11/12 13:25:24, Mads Ager wrote: > Could you add the > // Enable a specified feature within a scope. > comment. Done. http://codereview.chromium.org/385069/diff/1/10 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/385069/diff/1/10#newcode5110 Line 5110: if (Token::MUL == operation) __ fmuld(d5, d6, d7); On 2009/11/12 13:25:24, Mads Ager wrote: > Please remove extra spacing. I also added {} http://codereview.chromium.org/385069 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
