On 2015/03/04 13:43:50, Michael Starzinger wrote:
Summary of offline discussion.
https://codereview.chromium.org/976623002/diff/60001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/976623002/diff/60001/src/compiler.cc#newcode516
src/compiler.cc:516: !isolate()->serializer_enabled()) {
As discussed offline: Instead of narrowing the intake valve of this entry
into
the pipeline, I actually propose widening the intake valve of
Compiler::GetLazyCode when --turbo-filter=foo (and for now --always-opt)
is
passed. This should increase overall coverage instead of limiting it.
https://codereview.chromium.org/976623002/diff/60001/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):
https://codereview.chromium.org/976623002/diff/60001/test/cctest/test-serialize.cc#newcode1519
test/cctest/test-serialize.cc:1519: " 'use asm';"
As discussed offline: I don't think we want to trigger TurboFan with this
directive, because what we want to test here is not serialization of asm
code
but is serialization of non-context-specialized TurboFan code. So we
should
try
to use the regular --turbo-filter=foo approach here.
Michael, thanks for the suggestion and the patch!
https://codereview.chromium.org/976623002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
