looks good, just a small comment
https://codereview.chromium.org/976053002/diff/1/src/arm64/full-codegen-arm64.cc
File src/arm64/full-codegen-arm64.cc (right):
https://codereview.chromium.org/976053002/diff/1/src/arm64/full-codegen-arm64.cc#newcode2450
src/arm64/full-codegen-arm64.cc:2450: } else if (var->mode() == CONST &&
op != Token::INIT_CONST) {
Looks like the case at line 2488 anymore should be CONST_LEGACY and not
INIT_CONST_LEGACY. Just remove IsSignallingAssignmentToConst
altoghether.
https://codereview.chromium.org/976053002/diff/140001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/976053002/diff/140001/src/arm/full-codegen-arm.cc#newcode2764
src/arm/full-codegen-arm.cc:2764: } else if (var->mode() == CONST && op
!= Token::INIT_CONST) {
Looks like the case at line 2800 anymore should be mode == CONST_LEGACY
&& op != INIT_CONST_LEGACY.
Just remove IsSignallingAssignmentToConst altogether.
https://codereview.chromium.org/976053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
