thanks for looking at this. we try to keep our code as close to the style
guide
as possible. i'll discuss this change further with the team
https://codereview.chromium.org/978783002/diff/40001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/978783002/diff/40001/build/standalone.gypi#newcode527
build/standalone.gypi:527: 'CLANG_CXX_LIBRARY': 'libc++', #
-stdlib=libc++
On 2015/03/04 18:57:56, Nico wrote:
On 2015/03/04 18:52:37, jamesr wrote:
> We support OS X 10.6 which doesn't support C++11, IIUC
Yes, this won't work in a chromium build. (standalone.gypi isn't used
in a
chromium build, so this is fine, but if any v8 code that's used in
chromium
tries to use c++11 library features, things won't work)
okay, good to know. I was just trying to get the test working on my
machine, so i'll revert this file.
https://codereview.chromium.org/978783002/diff/40001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/978783002/diff/40001/include/v8.h#newcode854
include/v8.h:854: V8_INLINE UniquePersistent&
operator=(UniquePersistent<S>&& rhs) {
good catch, thanks
https://codereview.chromium.org/978783002/diff/40001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/978783002/diff/40001/test/cctest/test-api.cc#newcode3260
test/cctest/test-api.cc:3260: vector.push_back(std::move(global));
On 2015/03/04 18:52:37, jamesr wrote:
this won't compile on all platforms that chromium builds on. does this
build as
part of chromium builds or only v8 builds?
this test stuff is v8 only. I just wanted to check to see how many of
our builders could handle it.
https://codereview.chromium.org/978783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
