Reviewers: William Hesse, Description: Cleanup and fix generated comments in the top-level compiler.
Please review this at http://codereview.chromium.org/384087 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/arm/fast-codegen-arm.cc M src/fast-codegen.cc M src/ia32/fast-codegen-ia32.cc M src/x64/fast-codegen-x64.cc Index: src/ia32/fast-codegen-ia32.cc =================================================================== --- src/ia32/fast-codegen-ia32.cc (revision 3295) +++ src/ia32/fast-codegen-ia32.cc (working copy) @@ -322,6 +322,7 @@ void FastCodeGenerator::VisitDeclaration(Declaration* decl) { + Comment cmnt(masm_, "[ Declaration"); Variable* var = decl->proxy()->var(); ASSERT(var != NULL); // Must have been resolved. Slot* slot = var->slot(); Index: src/x64/fast-codegen-x64.cc =================================================================== --- src/x64/fast-codegen-x64.cc (revision 3295) +++ src/x64/fast-codegen-x64.cc (working copy) @@ -336,6 +336,7 @@ void FastCodeGenerator::VisitDeclaration(Declaration* decl) { + Comment cmnt(masm_, "[ Declaration"); Variable* var = decl->proxy()->var(); ASSERT(var != NULL); // Must have been resolved. Slot* slot = var->slot(); Index: src/fast-codegen.cc =================================================================== --- src/fast-codegen.cc (revision 3295) +++ src/fast-codegen.cc (working copy) @@ -76,7 +76,6 @@ void FastCodeGenerator::VisitDeclarations( ZoneList<Declaration*>* declarations) { - Comment cmnt(masm_, "[ Declarations"); int length = declarations->length(); int globals = 0; for (int i = 0; i < length; i++) { Index: src/arm/fast-codegen-arm.cc =================================================================== --- src/arm/fast-codegen-arm.cc (revision 3295) +++ src/arm/fast-codegen-arm.cc (working copy) @@ -123,7 +123,7 @@ // Put the lr setup instruction in the delay slot. The kInstrSize is // added to the implicit 8 byte offset that always applies to operations // with pc and gives a return address 12 bytes down. - Comment cmnt(masm_, "[ Stack check"); + { Comment cmnt(masm_, "[ Stack check"); __ LoadRoot(r2, Heap::kStackLimitRootIndex); __ add(lr, pc, Operand(Assembler::kInstrSize)); __ cmp(sp, Operand(r2)); @@ -133,6 +133,7 @@ RelocInfo::CODE_TARGET), LeaveCC, lo); + } { Comment cmnt(masm_, "[ Declarations"); VisitDeclarations(fun->scope()->declarations()); @@ -326,6 +327,7 @@ void FastCodeGenerator::VisitDeclaration(Declaration* decl) { + Comment cmnt(masm_, "[ Declaration"); Variable* var = decl->proxy()->var(); ASSERT(var != NULL); // Must have been resolved. Slot* slot = var->slot(); --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
