On 2015/03/05 11:35:16, Yang wrote:
On 2015/03/05 10:44:19, Erik Corry wrote:
> LGTM, but
>
> This is going to be very hard to debug if someone adds an external
reference
> like the counter, which can be either present or absent depending on
> configuration. You fixed that one in the CL, but when new ones arise,
it
will
> silently wire up all the external references after the extra one wrong.
It
might
> help to at least store the number of external references in the
snapshot and
> compare with the number in the equivalent table in the deserializing VM.
When using incompatible snapshots, I expect the version hashes to mismatch
first.
But I do see your point. Will add a field to the header for this
https://codereview.chromium.org/982773003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
