Overall looks like a big improvement. Some nits, plus as discussed, I'd
prefer
it if the api would always take a Map* rather than raw_transitions(). I
think
only transitions.* should look at raw_transitions().
https://codereview.chromium.org/980573002/diff/1/src/heap/objects-visiting-inl.h
File src/heap/objects-visiting-inl.h (right):
https://codereview.chromium.org/980573002/diff/1/src/heap/objects-visiting-inl.h#newcode590
src/heap/objects-visiting-inl.h:590: heap, HeapObject::RawField(map,
Map::kTransitionsOffset));
This keeps all simple transitions alive?
https://codereview.chromium.org/980573002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode2319
src/objects.cc:2319: Map* m = TransitionArray::GetTarget(transitions,
i);
write out names fully: map
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode2562
src/objects.cc:2562: if (m == NULL) break;
same here
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode2649
src/objects.cc:2649: Map* m = TransitionArray::SearchTransition(
same here
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode2964
src/objects.cc:2964: Map* m = TransitionArray::SearchTransition(new_map,
old_details.kind(),
same here
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode5728
src/objects.cc:5728: if (m != NULL) {
same here
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode5795
src/objects.cc:5795: if (m != NULL) {
same here
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode7355
src/objects.cc:7355: Map* m = TransitionArray::SearchTransition(*map,
kData, *name, attributes);
same here
https://codereview.chromium.org/980573002/diff/1/src/objects.cc#newcode7447
src/objects.cc:7447: TransitionArray::SearchTransition(*map, kAccessor,
*name, attributes);
same here
https://codereview.chromium.org/980573002/diff/1/src/transitions.cc
File src/transitions.cc (right):
https://codereview.chromium.org/980573002/diff/1/src/transitions.cc#newcode24
src/transitions.cc:24:
map->set_raw_transitions(*Map::WeakCellForMap(target));
Handle<WeakCell> cell = Map::WeakCellForMap(target);
map->set_raw_transitions(*cell);
https://codereview.chromium.org/980573002/diff/1/src/transitions.cc#newcode44
src/transitions.cc:44:
map->set_raw_transitions(*Map::WeakCellForMap(target));
Same as above
https://codereview.chromium.org/980573002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
