ptal
https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/917743002/diff/20001/src/isolate.cc#newcode557
src/isolate.cc:557: if (fun_name.is_null() || !fun_name->IsString())
On 2015/03/05 14:12:56, yurys wrote:
Can it ever be null?
Replaced with GetDataProperty
https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc#newcode14928
test/cctest/test-api.cc:14928:
TEST(GetStackTraceContainsFunctionsWithDisplayName) {
On 2015/03/05 14:12:56, yurys wrote:
...WithFunctionName
Done.
https://codereview.chromium.org/917743002/diff/20001/test/cctest/test-api.cc#newcode14948
test/cctest/test-api.cc:14948:
v8::V8::AddMessageListener(StackTraceDisplayNameListener);
On 2015/03/05 14:12:56, yurys wrote:
...DisplayName... -> ...FunctionName... here and below
Done.
https://codereview.chromium.org/917743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
