https://codereview.chromium.org/957273002/diff/190001/src/heap/store-buffer.cc
File src/heap/store-buffer.cc (right):
https://codereview.chromium.org/957273002/diff/190001/src/heap/store-buffer.cc#newcode267
src/heap/store-buffer.cc:267: const Address kRemovedSlot = NULL;
The NULL value is not much fun. Maybe we should point it to an address
in old space that does not move. Then we do not have to guard everywhere
against NULL pointer.
https://codereview.chromium.org/957273002/diff/190001/src/heap/store-buffer.cc#newcode287
src/heap/store-buffer.cc:287: old_top_ = new_top;
Why do you set old_top_ here, the old top should remain unchanged
because upper != old_top_
https://codereview.chromium.org/957273002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
