Reviewers: Toon Verwaest,
Message:
Hi Toon,
Here is the CL we discussed. I'll probably add a MIPS port as well to keep
builders happy.
I'll also turn off the flag which is on in the CL. But otherwise, it's
ready for
a look. Note, per our discussion that x64 has additional code to avoid
reading
the map word of the item in vector[slot]. For simplicity, the other
platforms
don't do this yet.
Thanks!
--Michael
Description:
Use platform specific stubs for vector-based Load/KeyedLoad.
A hydrogen code stub is not the best approach because it builds a frame
and doesn't have the technology to discard roots at tail call exits.
Platform-specific stubs provide much better performance at this point.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/988653003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1189, -250 lines):
M src/arm/code-stubs-arm.cc
M src/arm64/code-stubs-arm64.cc
M src/code-stubs.h
M src/code-stubs.cc
M src/code-stubs-hydrogen.cc
M src/flag-definitions.h
M src/ia32/code-stubs-ia32.cc
M src/ic/ic.cc
M src/objects.h
M src/type-feedback-vector.h
M src/type-feedback-vector.cc
M src/x64/code-stubs-x64.cc
M test/cctest/test-feedback-vector.cc
M test/mjsunit/mjsunit.status
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
