I am highly opposed to doing such optimizations in the AstGraphBuilder. The
logic for this needs to be kept in one place. It uses feedback from the
current
context slot content at compile time when we specialize for a context. I
agree
with what Ben said, ideally all of the machinery to take care of this should
already be in place.
In general moving optimization like this into the graph builder is a
slippery
slope. We'll end up with a gargantuan tangle similar to the HGraphBuilder.
If we ever want to do early optimizations in the AstGraphBuilder, we need to
find a clean interface that shares the logic with later optimization phases.
IMHO, duplicating the logic is not an option.
https://codereview.chromium.org/967093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
