LGTM with comments.
https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/981243002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2969
src/compiler/ast-graph-builder.cc:2969: return
NewNode(javascript()->StackCheck());
nit: I think we can now inline this into CreateGraphBody. WDYT?
https://codereview.chromium.org/981243002/diff/20001/src/compiler/js-generic-lowering.h
File src/compiler/js-generic-lowering.h (right):
https://codereview.chromium.org/981243002/diff/20001/src/compiler/js-generic-lowering.h#newcode54
src/compiler/js-generic-lowering.h:54: JSOperatorBuilder* javascript()
const { return jsgraph()->javascript(); }
Is this used anywhere? If it is then that's actually a problem, because
that means that generic lowering leaves JS nodes around. Let's drop it
again.
https://codereview.chromium.org/981243002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
