http://codereview.chromium.org/391014/diff/1/3 File src/runtime.cc (right):
http://codereview.chromium.org/391014/diff/1/3#newcode3390 Line 3390: CONVERT_SMI_CHECKED(radix, args[1]); On 2009/11/11 11:16:49, Erik Corry wrote: > This version doesn't work if the argument is not a Smi. It throws an exception > instead of just working. We should have a test that parseInt("100", 16.1) == > 256. My apologies, I was too fast with this comment. The 16.1 case is caught in the js code, so the patch LGTM. http://codereview.chromium.org/391014 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
