https://codereview.chromium.org/986643004/diff/1/src/arm/cpu-arm.cc
File src/arm/cpu-arm.cc (right):
https://codereview.chromium.org/986643004/diff/1/src/arm/cpu-arm.cc#newcode51
src/arm/cpu-arm.cc:51: register uint32_t scno asm("r7") =
__ARM_NR_cacheflush;
On 2015/03/07 18:34:49, bnoordhuis wrote:
I don't think it's safe to assume that the compiler will actually load
the value
into the register this way.
A peephole optimizer can't see into the asm block and won't realize
that the
register is actually used. It may opt to remove the load.
Please see
https://gcc.gnu.org/onlinedocs/gcc/Local-Reg-Vars.html#Local-Reg-Vars :
"However, using the variable as an input or output operand to the asm
guarantees that the specified register is used for that operand."
Note also that r0, r1, r2 are already being set in the same way. (Clang
has the same inline asm semantics as GCC, so it works the same way.)
https://codereview.chromium.org/986643004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
