General direction looks good.
https://codereview.chromium.org/983153002/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/983153002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2975
src/compiler/ast-graph-builder.cc:2975:
DCHECK_EQ(OperatorProperties::GetFrameStateInputCount(node->op()), 1);
Nit: DCHECK_XX(expected, actual)
https://codereview.chromium.org/983153002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2977
src/compiler/ast-graph-builder.cc:2977:
DCHECK_EQ(NodeProperties::GetFrameStateInput(node, 0)->opcode(),
Nit: DCHECK_XX(expected, actual)
https://codereview.chromium.org/983153002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2989
src/compiler/ast-graph-builder.cc:2989:
DCHECK_EQ(OperatorProperties::GetFrameStateInputCount(node->op()), 2);
Nit: DCHECK_XX(expected, actual)
https://codereview.chromium.org/983153002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2991
src/compiler/ast-graph-builder.cc:2991:
DCHECK_EQ(NodeProperties::GetFrameStateInput(node, 0)->opcode(),
Nit: DCHECK_XX(expected, actual)
https://codereview.chromium.org/983153002/diff/20001/src/compiler/ast-graph-builder.cc#newcode2996
src/compiler/ast-graph-builder.cc:2996:
DCHECK_EQ(NodeProperties::GetFrameStateInput(node, 1)->opcode(),
Nit: DCHECK_XX(expected, actual)
https://codereview.chromium.org/983153002/diff/20001/src/compiler/change-lowering.cc
File src/compiler/change-lowering.cc (right):
https://codereview.chromium.org/983153002/diff/20001/src/compiler/change-lowering.cc#newcode232
src/compiler/change-lowering.cc:232: DCHECK(FLAG_turbo_deoptimization ==
DCHECK_EQ?
https://codereview.chromium.org/983153002/diff/20001/src/compiler/js-generic-lowering.cc
File src/compiler/js-generic-lowering.cc (right):
https://codereview.chromium.org/983153002/diff/20001/src/compiler/js-generic-lowering.cc#newcode213
src/compiler/js-generic-lowering.cc:213: for (int i =
new_frame_state_count; i < old_frame_state_count; i++) {
This loop doesn't look right. If you remove input i, then input i+1
becomes input i, and so on. So you're probably removing non-frame-state
inputs here.
https://codereview.chromium.org/983153002/diff/20001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/983153002/diff/20001/src/compiler/js-inlining.cc#newcode379
src/compiler/js-inlining.cc:379:
DCHECK(OperatorProperties::GetFrameStateInputCount(node->op()) == 1);
DCHECK_EQ?
https://codereview.chromium.org/983153002/diff/20001/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/983153002/diff/20001/src/compiler/js-typed-lowering.cc#newcode650
src/compiler/js-typed-lowering.cc:650:
DCHECK(OperatorProperties::GetFrameStateInputCount(node->op()) == 1);
DCHECK_EQ?
https://codereview.chromium.org/983153002/diff/20001/src/compiler/js-typed-lowering.cc#newcode773
src/compiler/js-typed-lowering.cc:773: DCHECK(FLAG_turbo_deoptimization
==
DCHECK_EQ?
https://codereview.chromium.org/983153002/diff/20001/src/compiler/node-properties.cc
File src/compiler/node-properties.cc (right):
https://codereview.chromium.org/983153002/diff/20001/src/compiler/node-properties.cc#newcode62
src/compiler/node-properties.cc:62: DCHECK(index <
OperatorProperties::GetFrameStateInputCount(node->op()));
DCHECK_LT
https://codereview.chromium.org/983153002/diff/20001/src/compiler/node-properties.cc#newcode143
src/compiler/node-properties.cc:143: DCHECK(index <
OperatorProperties::GetFrameStateInputCount(node->op()));
DCHECK_LT
https://codereview.chromium.org/983153002/diff/20001/src/compiler/operator-properties.cc
File src/compiler/operator-properties.cc (right):
https://codereview.chromium.org/983153002/diff/20001/src/compiler/operator-properties.cc#newcode23
src/compiler/operator-properties.cc:23: int
OperatorProperties::GetFrameStateInputCount(const Operator* op) {
I think this method now deserves a unit test.
https://codereview.chromium.org/983153002/diff/20001/test/cctest/compiler/simplified-graph-builder.cc
File test/cctest/compiler/simplified-graph-builder.cc (right):
https://codereview.chromium.org/983153002/diff/20001/test/cctest/compiler/simplified-graph-builder.cc#newcode51
test/cctest/compiler/simplified-graph-builder.cc:51:
DCHECK(OperatorProperties::GetFrameStateInputCount(op) == 0);
DCHECK_EQ
https://codereview.chromium.org/983153002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
