Reviewers: Toon Verwaest, Hannes Payer,
Message:
Created Revert of Remove slots that point to unboxed doubles from the
StoreBuffer/SlotsBuffer.
Description:
Revert of Remove slots that point to unboxed doubles from the
StoreBuffer/SlotsBuffer. (patchset #4 id:230001 of
https://codereview.chromium.org/957273002/)
Reason for revert:
It caused a lot of Canary crashes.
Original issue's description:
Remove slots that point to unboxed doubles from the
StoreBuffer/SlotsBuffer.
The problem is that tagged slot could become a double slot after
migrating of
an object to another map with "shifted" fields (for example as a result of
generalizing immutable data property to a data field).
This CL also adds useful machinery that helps triggering incremental write
barriers.
BUG=chromium:454297
LOG=Y
Committed: https://crrev.com/9633ebabd405c264d33f603f8798c31f59418dcd
Cr-Commit-Position: refs/heads/master@{#27054}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:454297
Please review this at https://codereview.chromium.org/986283002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+11, -390 lines):
M src/flag-definitions.h
M src/heap/mark-compact.h
M src/heap/mark-compact.cc
M src/heap/spaces.h
M src/heap/store-buffer.h
M src/heap/store-buffer.cc
M src/objects.cc
M test/cctest/test-unboxed-doubles.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
