Reviewers: Yang, dcarney,
Message:
Created Revert of Store the next serial number in the function cache rather
than
in the isolate.Don't overwrite existi
Description:
Revert of Store the next serial number in the function cache rather than in
the
isolate.Don't overwrite existi (patchset #4 id:60001 of
https://codereview.chromium.org/988693003/)
Reason for revert:
This doesn't do what it's supposed to do. The problem seems to lie on the
blink
side, people aren't reusing their FunctionTemplates (or creating them when
not
necessary).
Original issue's description:
Don't overwrite existing serial numbers on the function template,
otherwise
instantiating the function for a new context causes the serial number to
bump.
Committed: https://crrev.com/1e638c3610ec6938e5fb16c42018642195782fb2
Cr-Commit-Position: refs/heads/master@{#27048}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Please review this at https://codereview.chromium.org/993533003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
