On 2015/03/09 09:57:30, Benedikt Meurer wrote:
https://codereview.chromium.org/985713003/diff/20001/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/985713003/diff/20001/src/compiler/js-typed-lowering.cc#newcode231
src/compiler/js-typed-lowering.cc:231: return graph()->NewNode(op,
frame_state->InputAt(0),
As discussed offline, please add something like
NodeProperties::Clone(Node*)
here with set_op() on the clone.
https://codereview.chromium.org/985713003/diff/20001/src/compiler/js-typed-lowering.cc#newcode270
src/compiler/js-typed-lowering.cc:270: return graph()->NewNode(op,
frame_state->InputAt(0),
As discussed offline, please add something like
NodeProperties::Clone(Node*)
here with set_op() and ReplaceInput() on the clone.
Unfortunately, I need a graph to create new nodes. As NodeProperties does
not
know anything about the graph, maybe we should keep the code as is.
https://codereview.chromium.org/985713003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
