https://codereview.chromium.org/985453003/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/985453003/diff/80001/src/heap/mark-compact.cc#newcode3076
src/heap/mark-compact.cc:3076: start_index--;
On 2015/03/09 10:39:17, Erik Corry wrote:
If start_index was zero, it goes negative here, which is going to
cause chaos!
start_index will never be zero. It will always be larger or equal than
Address cell_base = p->area_start();
unsigned int cell_base_start_index = Bitmap::IndexToCell(
Bitmap::CellAlignIndex(p->AddressToMarkbitIndex(cell_base)));
However, we should not go until 0 but should stop at base_start_index.
Changed.
https://codereview.chromium.org/985453003/diff/80001/src/heap/mark-compact.cc#newcode3095
src/heap/mark-compact.cc:3095: // Find the first live object in the
cell.
On 2015/03/09 10:46:26, Erik Corry wrote:
Shouldn't this be the _last_ live object in the cell?
Done. It depends on your point of view.
https://codereview.chromium.org/985453003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
