https://codereview.chromium.org/985643003/diff/20001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/985643003/diff/20001/src/compiler/ast-graph-builder.cc#newcode1394
src/compiler/ast-graph-builder.cc:1394:
javascript()->CallRuntime(Runtime::kThrowIfStaticPrototype, 1);
On 2015/03/06 13:05:18, Michael Starzinger wrote:
On 2015/03/06 11:51:29, arv wrote:
> I'm tempted to do the `if (name === 'prototype') { ... }` here
instead of
doing
> that in the runtime function.
I would be fine with having the comparison inline if you like to go
for it. You
could use JSStrictEqual and the IfBuilder to construct that. Check out
AstGraphBuilder::BuildStackCheck for inspiration on how this might
look like.
I think inline comparison is better overall since it is one runtime call
less on happy path. But ok either way.
https://codereview.chromium.org/985643003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
