lgtm
On 2015/03/10 05:35:41, bashi1 wrote:
I need this to fix the compile error which occurred when I trying to use
As<Boolean>.
https://codereview.chromium.org/986573002/#msg8
right, sorry i forgot this one was unimplemented
Similarly, V8 doesn't provide Cast() for Int32 and Uint32. I assume that
we
should use ToInt32() or ToUint32() even when IsInt32() (or IsUint32()) is
true,
given that it seems there is no trivial way to implement
v8::internal::Object::isInt32().
that's correct, Cast doesn't make sense for integer types, as js doesn't
provide them
https://codereview.chromium.org/990943003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.