Reviewers: jarin,
Message:
Seriously, the loop that contains runtime asserts that was put in to make
fuzzing happy, now has a "bug" and makes fuzzing unhappy. Seriously? What
are we
doing here?
Please forgive me for not adding a "regression test" for this.
Description:
Fix runtime assert in %LiveEditCheckAndDropActivations.
[email protected]
BUG=chromium:465663
LOG=n
Please review this at https://codereview.chromium.org/989743004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -2 lines):
M src/runtime/runtime-liveedit.cc
Index: src/runtime/runtime-liveedit.cc
diff --git a/src/runtime/runtime-liveedit.cc
b/src/runtime/runtime-liveedit.cc
index
b453d154592f235c4f14be702d44a7ef4b3d868c..e4c644e168182b66ee579cbcd7470190364ff69f
100644
--- a/src/runtime/runtime-liveedit.cc
+++ b/src/runtime/runtime-liveedit.cc
@@ -234,8 +234,9 @@
RUNTIME_FUNCTION(Runtime_LiveEditCheckAndDropActivations) {
RUNTIME_ASSERT(shared_array->HasFastElements())
int array_length = Smi::cast(shared_array->length())->value();
for (int i = 0; i < array_length; i++) {
- Handle<Object> element =
- Object::GetElement(isolate, shared_array, i).ToHandleChecked();
+ Handle<Object> element;
+ ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+ isolate, element, Object::GetElement(isolate, shared_array, i));
RUNTIME_ASSERT(
element->IsJSValue() &&
Handle<JSValue>::cast(element)->value()->IsSharedFunctionInfo());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
