Reviewers: loislo, Yang,
Description:
Remove deprecated CpuProfiler methods
BUG=None
LOG=Y
Please review this at https://codereview.chromium.org/992193002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -30 lines):
M include/v8-profiler.h
M src/api.cc
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index
d0215205f5fa97d8eadc1f2547df734f53c11a24..07f34e1385242e3bc95c7b9e7d1f935135a1b59a
100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -168,21 +168,12 @@ class V8_EXPORT CpuProfiler {
*/
void StartProfiling(Handle<String> title, bool record_samples = false);
- /** Deprecated. Use StartProfiling instead. */
- V8_DEPRECATED("Use StartProfiling",
- void StartCpuProfiling(Handle<String> title,
- bool record_samples = false));
-
/**
* Stops collecting CPU profile with a given title and returns it.
* If the title given is empty, finishes the last profile started.
*/
CpuProfile* StopProfiling(Handle<String> title);
- /** Deprecated. Use StopProfiling instead. */
- V8_DEPRECATED("Use StopProfiling",
- const CpuProfile* StopCpuProfiling(Handle<String> title));
-
/**
* Tells the profiler whether the embedder is idle.
*/
@@ -272,10 +263,6 @@ class V8_EXPORT HeapGraphNode {
SnapshotObjectId GetId() const;
/** Returns node's own size, in bytes. */
- V8_DEPRECATED("Use GetShallowSize instead",
- int GetSelfSize() const);
-
- /** Returns node's own size, in bytes. */
size_t GetShallowSize() const;
/** Returns child nodes count of the node. */
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
c8e70931c73171d3f53cfc54a40619ee9c15277a..746865767bbf37f1c436f1d09b3773ea11e7cad3
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -7502,11 +7502,6 @@ void CpuProfiler::StartProfiling(Handle<String>
title, bool record_samples) {
}
-void CpuProfiler::StartCpuProfiling(Handle<String> title, bool
record_samples) {
- StartProfiling(title, record_samples);
-}
-
-
CpuProfile* CpuProfiler::StopProfiling(Handle<String> title) {
return reinterpret_cast<CpuProfile*>(
reinterpret_cast<i::CpuProfiler*>(this)->StopProfiling(
@@ -7514,11 +7509,6 @@ CpuProfile*
CpuProfiler::StopProfiling(Handle<String> title) {
}
-const CpuProfile* CpuProfiler::StopCpuProfiling(Handle<String> title) {
- return StopProfiling(title);
-}
-
-
void CpuProfiler::SetIdle(bool is_idle) {
i::Isolate* isolate = reinterpret_cast<i::CpuProfiler*>(this)->isolate();
v8::StateTag state = isolate->current_vm_state();
@@ -7599,13 +7589,6 @@ SnapshotObjectId HeapGraphNode::GetId() const {
}
-int HeapGraphNode::GetSelfSize() const {
- size_t size = ToInternal(this)->self_size();
- CHECK(size <= static_cast<size_t>(internal::kMaxInt));
- return static_cast<int>(size);
-}
-
-
size_t HeapGraphNode::GetShallowSize() const {
return ToInternal(this)->self_size();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
